Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-1491 Support vsphere as a backend #549

Merged
merged 28 commits into from
May 14, 2024
Merged

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Mar 8, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 87.96296% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 85.92%. Comparing base (b8b0d33) to head (62e6a17).

Files Patch % Lines
runner_manager/backend/vsphere.py 86.31% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   85.98%   85.92%   -0.07%     
==========================================
  Files          31       32       +1     
  Lines        1249     1357     +108     
==========================================
+ Hits         1074     1166      +92     
- Misses        175      191      +16     
Flag Coverage Δ
api 64.25% <36.11%> (-2.44%) ⬇️
unit 68.31% <36.11%> (-3.03%) ⬇️
vsphere 40.30% <87.96%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet marked this pull request as ready for review April 2, 2024 17:21
@tcarmet tcarmet requested a review from a team as a code owner April 2, 2024 17:21
@tcarmet tcarmet merged commit 74ea1ac into main May 14, 2024
13 checks passed
@tcarmet tcarmet deleted the feature/PTFE-1491-vsphere-backend branch May 14, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants